Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop rule simplification #86

Open
wants to merge 74 commits into
base: master
Choose a base branch
from
Open

Develop rule simplification #86

wants to merge 74 commits into from

Conversation

gfngfn
Copy link
Contributor

@gfngfn gfngfn commented Dec 26, 2022 •
edited
Loading

This PR implements a simplification algorithm, Simplification.simplify, which reduces duplicate rules or redundant clauses in a rule.

Note: The present PR includes #72. You can see the essential diff made by this PR here.

Some tests have been added in src/test/simplification_test.ml for testing the simplification.

I would appreciate any feedbacks or suggestions.

gfngfn added 30 commits June 15, 2022 23:19
@gfngfn
begin to develop the operation-based conversion
dcf53cf
@gfngfn
use 'ResultMonad'
9837564
@gfngfn
develop 'decompose_body'
3d0f0ed
@gfngfn
develop how to validate rule bodies
d037f42
@gfngfn
develop 'Subst'
055e0c3
@gfngfn
develop how to extend substitutions
d0c1d5c
@gfngfn
develop how to extend substitutions and eliminate consumed equality c…
6566652 
…onstraints
@gfngfn
begin to build SQL queries
14eebb4
@gfngfn
build SQL SELECT clauses
7333174
@gfngfn
build SQL FROM clauses and use comparison constraints
3377f93
@gfngfn
basically complete 'convert_to_operation_based_sql'
d837da0
@gfngfn
implement 'sql_of_vterm_new'
797205e
@gfngfn
implement 'sql_vterm_of_arg'
89140b0
@gfngfn
refactor 'SqlFromTable'
c15194a
@gfngfn
use 'colnamtab' and 'symtkey' to implement 'get_column_names_from_table'
a88b9f6
@gfngfn
begin to add unit tests
187eb3c
@gfngfn
refactor 'convert_to_operation_based_sql'
61dff32
@gfngfn
develop tests for 'convert_to_operation_based_sql'
7b73c7c
@gfngfn
develop tests for 'convert_to_operation_based_sql' (2)
5f290f5
@gfngfn
make cosmetic changes of output SQL queries
c742437
@gfngfn
refactor tests
5e92a10
@gfngfn
refactor tests for running multiple test cases
321a3b3
@gfngfn
add a test case '1st rule'
7c00bde
@gfngfn
add a test case '2nd rule'
b8da994
@gfngfn
slight cosmetic changes
2df7b44
@gfngfn
slight cosmetic changes (2)
eaf450c
@gfngfn
refactor tests about module organization
47d258d
@gfngfn
refactor tests about module organization (by moving tests into 'src/t…
3bdd426 
…est')
@gfngfn
add 'convert_expr_to_operation_based_sql'
2977bb3
@gfngfn
develop 'convert_expr_to_operation_based_sql'
e37f90d
gfngfn and others added 23 commits July 21, 2022 00:34
@gfngfn
fix how to output 'FROM' clauses about referring to temporary tables
b6d4778
@gfngfn
fix how to output 'FROM' clauses in subqueries corresponding to negat…
10ab5fd 
…ive atoms
@gfngfn
fix tests
d079522
@gfngfn
begin to develop simplification.ml
168b133
@gfngfn
develop convert_{head,body}_rterm etc.
fd13557
@gfngfn
develop simplification.ml slightly
4966f2e
@gfngfn
introduce equation_map for representing equations internally
d7767dc
@gfngfn
implement rule_equal
f445060
@gfngfn
implement erase_sole_occurrences
07ddba7
@gfngfn
develop remove_looser_terms
6f04658
@gfngfn
implement has_contradicting_body etc.
caa0386
@gfngfn
begin to develop tests for simplification.ml
63dddfd
@gfngfn
slightly develop tests
35c4727
@gfngfn
add a test case and check that it fails
7b574c9
@gfngfn
fix remove_looser_{positive,negative}_terms (and this makes the tes…
3678c88 
…t pass)
@gfngfn
add more tests (and confirm that they pass)
8ad1941
@gfngfn
add the interface file simplification.mli
5f9daf5
@gfngfn
begin to support non-equality constraints
9cab7d7
@gfngfn
non-equality constraints
e3b876e
@gfngfn
add a test (32) for Simplification
6f3da8f
@gfngfn
begin to develop remove_duplicate_rules
1abbcb2
@gfngfn
begin to develop are_alpha_equivalent_rules
62281bd
@gfngfn
implement are_alpha_equivalent_rules
adfaba2
@gfngfn gfngfn changed the title [WIP] Develop rule simplification Develop rule simplification Dec 26, 2022
@gfngfn gfngfn mentioned this pull request Jan 12, 2023
Merged
@gfngfn gfngfn marked this pull request as ready for review January 26, 2023 09:23
@gfngfn gfngfn mentioned this pull request Mar 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gfngfn