Patch

danog · Jan 15, 2024 · c9fe76c · c9fe76c
1 parent 3f82312
commit c9fe76c
Show file tree

Hide file tree

Showing 7 changed files with 28 additions and 27 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php
@@ -1260,7 +1260,7 @@ private static function handleByRefReadonlyArg(
         Context $context,
         PhpParser\Node\Expr\PropertyFetch $stmt,
         string $fq_class_name,
-        string $prop_name
+        string $prop_name,
     ): void {
         $property_id = $fq_class_name . '::$' . $prop_name;
 

diff --git a/src/Psalm/Internal/Provider/ReturnTypeProvider/FilterInputReturnTypeProvider.php b/src/Psalm/Internal/Provider/ReturnTypeProvider/FilterInputReturnTypeProvider.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Psalm\Internal\Provider\ReturnTypeProvider;
 
 use Psalm\Internal\Analyzer\Statements\Expression\Fetch\VariableFetchAnalyzer;

diff --git a/src/Psalm/Internal/Provider/ReturnTypeProvider/FilterUtils.php b/src/Psalm/Internal/Provider/ReturnTypeProvider/FilterUtils.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Psalm\Internal\Provider\ReturnTypeProvider;
 
 use PhpParser\Node\Arg;
@@ -108,12 +110,11 @@ public static function missingFirstArg(Codebase $codebase): Union
         return Type::getNull();
     }
 
-    /** @return int|Union|null */
     public static function getFilterArgValueOrError(
         Arg $filter_arg,
         StatementsAnalyzer $statements_analyzer,
-        Codebase $codebase
-    ) {
+        Codebase $codebase,
+    ): int|Union|null {
         $filter_arg_type = $statements_analyzer->node_data->getType($filter_arg->value);
         if (!$filter_arg_type) {
             return null;
@@ -154,8 +155,8 @@ public static function getOptionsArgValueOrError(
         Codebase $codebase,
         CodeLocation $code_location,
         string $function_id,
-        int $filter_int_used
-    ) {
+        int $filter_int_used,
+    ): array|Union|null {
         $options_arg_type = $statements_analyzer->node_data->getType($options_arg->value);
         if (!$options_arg_type) {
             return null;
@@ -339,7 +340,7 @@ public static function missingFilterCallbackCallable(
         string $function_id,
         CodeLocation $code_location,
         StatementsAnalyzer $statements_analyzer,
-        Codebase $codebase
+        Codebase $codebase,
     ): Union {
         IssueBuffer::maybeAdd(
             new InvalidArgument(
@@ -397,7 +398,7 @@ public static function checkRedundantFlags(
         Union $fails_type,
         StatementsAnalyzer $statements_analyzer,
         CodeLocation $code_location,
-        Codebase $codebase
+        Codebase $codebase,
     ): ?Union {
         $all_filters = self::getFilters($codebase);
         $flags_int_used_rest = $flags_int_used;
@@ -500,7 +501,7 @@ public static function getOptions(
         StatementsAnalyzer $statements_analyzer,
         CodeLocation $code_location,
         Codebase $codebase,
-        string $function_id
+        string $function_id,
     ): array {
         $default = null;
         $min_range = null;
@@ -605,16 +606,12 @@ public static function getOptions(
         return [$default, $min_range, $max_range, $has_range, $regexp];
     }
 
-    /**
-     * @param float|int|null $min_range
-     * @param float|int|null $max_range
-     */
     protected static function isRangeValid(
-        $min_range,
-        $max_range,
+        float|int|null $min_range,
+        float|int|null $max_range,
         StatementsAnalyzer $statements_analyzer,
         CodeLocation $code_location,
-        string $function_id
+        string $function_id,
     ): bool {
         if ($min_range !== null && $max_range !== null && $min_range > $max_range) {
             IssueBuffer::maybeAdd(
@@ -637,8 +634,6 @@ protected static function isRangeValid(
      *
      * @psalm-suppress ComplexMethod
      * @param Union|null $not_set_type null if undefined filtered variable will return $fails_type
-     * @param float|int|null $min_range
-     * @param float|int|null $max_range
      * @param non-falsy-string|true|null $regexp
      */
     public static function getReturnType(
@@ -652,10 +647,10 @@ public static function getReturnType(
         Codebase $codebase,
         string $function_id,
         bool $has_range,
-        $min_range,
-        $max_range,
-        $regexp,
-        bool $in_array_recursion = false
+        float|int|null $min_range,
+        float|int|null $max_range,
+        string|bool|null $regexp,
+        bool $in_array_recursion = false,
     ): Union {
         // if we are inside a recursion of e.g. array<never, never>
         // it will never fail or change the type, so we can immediately return
@@ -1472,7 +1467,7 @@ private static function addReturnTaint(
         StatementsAnalyzer $statements_analyzer,
         CodeLocation $code_location,
         Union $return_type,
-        string $function_id
+        string $function_id,
     ): Union {
         if ($statements_analyzer->data_flow_graph
             && !in_array('TaintedInput', $statements_analyzer->getSuppressedIssues())

diff --git a/src/Psalm/Issue/RedundantFlag.php b/src/Psalm/Issue/RedundantFlag.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Psalm\Issue;
 
 final class RedundantFlag extends CodeIssue

diff --git a/src/Psalm/Issue/TaintedXpath.php b/src/Psalm/Issue/TaintedXpath.php
@@ -6,5 +6,5 @@
 
 final class TaintedXpath extends TaintedInput
 {
-    public const SHORTCODE = 322;
+    public const SHORTCODE = 328;
 }
diff --git a/src/Psalm/Storage/UnserializeMemoryUsageSuppressionTrait.php b/src/Psalm/Storage/UnserializeMemoryUsageSuppressionTrait.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Psalm\Storage;
 
 /**

diff --git a/tests/Internal/Codebase/MethodGetCompletionItemsForClassishThingTest.php b/tests/Internal/Codebase/MethodGetCompletionItemsForClassishThingTest.php
@@ -281,7 +281,7 @@ class A {
                 'magicObjProp2',
 
                 'magicObjMethod',
-                'magicStaticMethod',
+                //'magicStaticMethod',
 
                 'publicObjProp',
                 'protectedObjProp',
@@ -362,7 +362,7 @@ abstract class A {
                 'magicObjProp2',
 
                 'magicObjMethod',
-                'magicStaticMethod',
+                //'magicStaticMethod',
 
                 'publicObjProp',
                 'protectedObjProp',
@@ -440,7 +440,7 @@ class A extends C {
                 'magicObjProp2',
 
                 'magicObjMethod',
-                'magicStaticMethod',
+                //'magicStaticMethod',
 
                 'publicObjProp',
                 'protectedObjProp',