Removing max height of histogram #17045
Conversation
also limited. This is not desirable, though, since screens with high
resolution make the histogram small and hard to read, particularly when
using the scope. This commit fixes this by doing two things:
1) Making functions auto-detect whether they should use height or
aspect ratio to manage the container size by checking whether
the passed "config_str" variable refers to height or aspect ratio
-- Note: this is actually safer anyway, since it was perfectly
possible before to pass an AR request to a height function
2) Changing the histogram back to using aspect ratio instead of height
|
Limited height histogram/waveform is actually some kind of regression as it seems there were no such limitation in past releases. A tall waveform is better for distinction of tones. |
|
Is there anything else needed from me for this to get added? Would it be useful for me (or would it be useful in the future) to open a ticket to track/document the issue better? |
|
This pull request has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please verify it has no conflicts with the master branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
| { | ||
| // Determine whether to use height or aspect ratio based on config_str | ||
| if(g_str_has_suffix(config_str, "graphheight")) { |
There was a problem hiding this comment.
style: The { should be on next line. See current code.
| const int height = dt_conf_get_int(config_str) + delta_y; | ||
| dt_conf_set_int(config_str, height); | ||
| dtgtk_drawing_area_set_height(w, height); | ||
| if(use_height) { |
| dt_conf_set_int(config_str, event->y); | ||
| const int height = dt_conf_get_int(config_str); | ||
| dtgtk_drawing_area_set_height(widget, height); | ||
| if(use_height) { |
|
@johnlb : Sorry for the long delay before the review! |
TurboGit
added
feature: enhancement
When implementing height limits on modules, the histogram container was also limited. This is not desirable, though, since screens with high resolution make the histogram small and hard to read, particularly when using the scope. This commit fixes this by doing two things:
Making functions auto-detect whether they should use height or
aspect ratio to manage the container size by checking whether
the passed "config_str" variable refers to height or aspect ratio
-- Note: this is actually safer anyway, since it was perfectly
possible before to pass an AR request to a height function
Changing the histogram back to using aspect ratio instead of height