Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Make the active state of area color mapping more visible #17804

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

victoryforce
Copy link
Collaborator

Why do we need it?

The English original, "area color mapping (active)", is quite short, so even with very narrowed panels, this text will be visible completely. But translations into many other languages ​​give a significantly longer text, the end of which can be replaced by ellipsis points in the narrow panel. If this happens, our efforts to inform the user of the active state of the mapping will fail.

You can say that it only has to do with translations and it really is, the original is safely short. But the translators will obviously preserve the word order of the original in the translation. Therefore, I suggest writing "(active) area color mapping" in the original text so that the user is guaranteed to see whether the mapping is active.

@TurboGit
Copy link
Member

I don't like having the (active) first on the string, this does not read proper to me and that's not something I've seen on other software.

@TurboGit TurboGit added the controversial this raises concerns, don't move on the technical work before reaching a consensus label Nov 12, 2024
@victoryforce
Copy link
Collaborator Author

As I wrote, there is no problem with this text in the English language. I fixed the Ukrainian translation after noticing an issue with my narrow panels. There remains the problem of the possible cutting of the most important part of the text in a narrow panel in other translations. If we don't really care about it (or we will somehow separately inform the translators about the specificity of the translation of this string), then I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controversial this raises concerns, don't move on the technical work before reaching a consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants