Fixed the issue with multiple pipeline navigation #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have multiple broadway pipelines, the pipeline graph is not changed based on the selected pipeline menu. But works on reloading the page. The issue is with
broadway_dashboard 0.4.0
andphoenix_live_dashboard 0.8.0
broadway_dashboard.mp4
But this works fine with
broadway_dashboard 0.3.0
andphoenix_live_dashboard 0.7.0
This is because, in the latest version of broadway_dashboard, the method is not passed as expected with the
phoenix_live_dashboard 0.8.0
. So by default,phoenix_live_dashboard
considers this as patch navigation. But as we don't have anyhandle_params
, it is not navigating.Since
broadway_dashboard 0.3.0
passes redirect to phoenix_live_dashboard, it implements push_redirect(deprecated now) of live_view. Fixed this by passing navigate, as a separate attribute.This is my first open-source contribution. Correct me on my approach to this. 🙂