Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and fix 2 warnings #34

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ jobs:
matrix:
include:
- pair:
elixir: 1.12.3
otp: 24.3.4
elixir: 1.13.4
otp: 24.3.4.17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanjacosic Can we support Elixir 1.17.x and Erlang OTP 27.x in the CI pipeline?

- pair:
elixir: 1.16.0
otp: 26.2.1
Expand Down
2 changes: 1 addition & 1 deletion lib/broadway_dashboard.ex
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ defmodule BroadwayDashboard do
true ->
nav = pipelines |> hd() |> inspect()
to = live_dashboard_path(socket, socket.assigns.page, nav: nav)
{:ok, push_redirect(socket, to: to)}
{:ok, push_navigate(socket, to: to)}
end

{:error, error} ->
Expand Down
4 changes: 2 additions & 2 deletions lib/broadway_dashboard/pipeline_graph.ex
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ defmodule BroadwayDashboard.PipelineGraph do
# This module is responsible for calculating the
# layers of a given pipeline.

alias BroadwayDashboard.LiveDashboard.LayeGraphComponent
alias Phoenix.LiveDashboard.LayeredGraphComponent

@type topology_workload :: %{
:name => atom(),
Expand All @@ -16,7 +16,7 @@ defmodule BroadwayDashboard.PipelineGraph do
}
@type topology_workload_item :: {:producers | :processors | :batchers, topology_workload()}

@spec build_layers([topology_workload_item()]) :: [LayeGraphComponent.layer()]
@spec build_layers([topology_workload_item()]) :: [LayeredGraphComponent.layer()]
def build_layers(topology_workloads) when is_list(topology_workloads) do
# The order of steps is important here.
steps =
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ defmodule BroadwayDashboard.MixProject do
[
app: :broadway_dashboard,
version: @version,
elixir: "~> 1.12",
elixir: "~> 1.13",
start_permanent: Mix.env() == :prod,
elixirc_paths: elixirc_paths(Mix.env()),
name: "BroadwayDashboard",
Expand Down
Loading