[Fixes #35] Changing <All Time> label and hint #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustela
changed the title
josevalim
approved these changes
Oct 3, 2024
philss
approved these changes
Oct 3, 2024
|
@mustela thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request tries to improve the label and hit on the dashboard page to make them more intuitive for users.
The original title “All time” and the hint “Messages since start” could be ambiguous for users trying to understand what the statistics represent. Changing the title to “Successful” and clarifying the hint helps users better understand the metrics being displayed, making the UI more user-friendly.