Add Mox.get_executed_calls/1 #140
Conversation
| @@ -812,7 +817,7 @@ defmodule Mox do | |||
| def __dispatch__(mock, name, arity, args) do | |||
| all_callers = [self() | caller_pids()] | |||
|
|
|||
| case Mox.Server.fetch_fun_to_dispatch(all_callers, {mock, name, arity}) do | |||
| case Mox.Server.fetch_fun_to_dispatch(all_callers, {mock, name, arity}, args) do | |||
There was a problem hiding this comment.
This means we are copying all argument data to a separate process. :(
There was a problem hiding this comment.
Right, is that an issue in tests? We would do the same when using the send/2 trick to send calls to the parent process.
Any ideas on how to do this without copying the args?
There was a problem hiding this comment.
the problem is that this enables this for everything by default. We would need to store it somewhere if we want to collect or not.
| @@ -763,6 +763,11 @@ defmodule Mox do | |||
| verify_mock_or_all!(self(), mock, :test) | |||
| end | |||
|
|
|||
| def get_executed_calls(mock) do | |||
| validate_mock!(mock) | |||
| Mox.Server.get_executed_calls(mock) | |||
There was a problem hiding this comment.
Also, is this safe to execute concurrently? It doesn't look like it is the case. :(
There was a problem hiding this comment.
It definitely isn't 😉 Will have to figure it out with the allowance.
|
@josevalim this is just to get the ball rolling. Are we interested in this feature? If so, we can try to hash out the things that are borked 🥦 |
|
Yeah... I give up on this, it's complex and I don't have the time just right now 😄 For now, the |
Kicking off some code for #133.
I have no clue what I'm doing, I'm not familiar with Mox's codebase so I'm just sort of winging it.