Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PL] fix watermark test #12

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[PL] fix watermark test #12

wants to merge 3 commits into from

Conversation

PawaritL
Copy link

Changes

  • Fix watermarking unit test (sorry it's a bit long but it helps to simulate a watermarked stream properly)
  • Changed the schema for the watermarking exercise to also return some other sanity check metrics
  • Replaced the word Stateful with Structured. This exercise isn't really proper stateful streaming yet
  • Added a clean-up section at the end

What's missing:

  • To always run dbutils.fs.rm(..., True) no matter if the watermarking unit test passes or fails

PawaritL and others added 3 commits May 10, 2023 01:57
[PL] fix watermark test
66796ad 
Other changes
- Changed the schema for the watermarking exercise to also return some other sanity check metrics
- Replaced the word Stateful with Structured. This exercise isn't really proper stateful streaming yet
@PawaritL
[PL] add comments for Watermarking simulation loop
8b38425
@PawaritL
[PL] rename variable for clarity
8cef90e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PawaritL