Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

left not inner join #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ryandawsonuk
Copy link

Here the instructs say to use a left join:

https://github.com/ryandawsonuk/exercise-ev-databricks/blob/54cfe9ce55904d92da6808bd26e28a0210834be8/batch-processing-gold-2/Batch%20Processing%20-%20Gold%20-%20Solutions.py#L94

But the solution uses an inner join. They actually give the same results as it happens that all requests do have responses. But conceptually I think a left join is intended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant