Switching to Ruff for formatting and linting #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
requested review from
andrefurlan-db and
rcypher-databricks
as code owners
alexguo-db
reviewed
Nov 19, 2024
dev-requirements.txt
Outdated
| @@ -1,3 +1,5 @@ | |||
| ruff | |||
|
|
|||
| black~=24.3.0 | |||
There was a problem hiding this comment.
Can we remove old formatters here?
alexguo-db
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flake8 is ancient, and Ruff can replace black and flake8, plus has future linter expansion opportunities. For this PR, there are a few files that are modified by running Ruff format, but I'm keeping significant format cleanup to a separate PR. Getting rid of pre-commit until I've finished redoing the linting to run everything through Ruff.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.