-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building a DuckDB Playground with Daytona #117
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
You mind reviewing this PR too @mojafa ? |
@c0d33ngr here's my review:
Please fix the issues. |
@mojafa thanks for the review. I'll fix them |
Please assign me to the issue @mojafa |
Done |
@c0d33ngr any updates? |
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Hi @mojafa sorry for the delays I think I've updated most of the issues you found in the PR. The one remaining ones should be the broken links |
@mojafa I think what you meant of broken link or raw reference is as a result of the spacing between some Some markdown files in Datyona definition directory has spacing between their names and including dashes or underscore won't point to the file in Daytona CMS - I think so |
@mojafa what do you think? |
@c0d33ngr please fix these 👆🏽 |
@mojafa I've fixed them with |
@c0d33ngr this PR fails DCO checks |
oh.. I did it from GitHub web with my phone |
please fix |
Take your time, don't be in a hurry. Quality of speed |
@c0d33ngr also please run: but mostly here:
Formatting and Style Errors
|
Writer's Checklist
Writing Structure
code elements
andMarkdown format
where appropriate.Fact-Checking
Asset Management
/assets
folder.YYYYMMDD_title_of_the_article_IMG_NAME_NO.png
.Interlinking
CTRL+F
to search for relevant keywords in:Glossary/Definitions
/defitnitions
folder.Review and Edit