Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to nan 2.1.0. #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update to nan 2.1.0. #10

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 12, 2015

package.json had LF linebreaks instead of CRLF(most of tthe files have CRLF, so I changed that one as well). I don't know much about cpp or nan, but it compiles again on Node.js 5.x and the examples work :-)

Not sure about this line:
Nan::Persistent constructor_template;

@jkins
Copy link

jkins commented Feb 14, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant