Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: align properties with figma to have a nearly 1:1 relationship #3459

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

feat: align properties with figma to have a nearly 1:1 relationship #3459

wants to merge 25 commits into from
+307 −118

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Nov 13, 2024

Proposed changes

align properties with figma to have a nearly 1:1 relationship

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions github-actions bot added 🏗foundations Changes inside foundations folder 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-figma-properties-alignment

@nmerget nmerget marked this pull request as draft November 13, 2024 11:56
@nmerget nmerget added this to the v0.6.0 milestone Nov 13, 2024
@nmerget nmerget marked this pull request as ready for review November 14, 2024 07:23
@nmerget nmerget enabled auto-merge (squash) November 14, 2024 08:22
@mfranzke mfranzke mentioned this pull request Nov 19, 2024
Open
@mfranzke mfranzke self-assigned this Nov 21, 2024
@nmerget
fix: issues with misplaced icons
4059b79
@nmerget
Merge remote-tracking branch 'origin/main' into feat-figma-properties…
578d1d7 
…-alignment

# Conflicts:
#	packages/components/src/components/accordion-item/accordion-item.lite.tsx
@github-actions github-actions bot added the 📕documentation Improvements or additions to documentation label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

@mfranzke mfranzke Awaiting requested review from mfranzke mfranzke is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mfranzke mfranzke

Labels
🏘components Changes inside components folder 📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerget @mfranzke