-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vr): Save original non-standard VR #414
Conversation
✅ Deploy Preview for dcmjs2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This sounds reasonable, but a couple things. First, we need to have commits follow the commit message format. Here it would be something like Also, please add a test for this. It can be simple, just make a dataset from scratch that has the incorrect VR and then run it through the round trip (go from namified javascript object to part 10, then back from part10 to namified object and back to part 10 and then back to namified and confirm that desired VR has been preserved). |
…tionary and use saved VR in processing denaturalizeDataset function
623f2be
to
2d479cd
Compare
Hello, I renamed pr and commits by requirements and added simple test for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM 👍
🎉 This PR is included in version 0.37.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hello, I encountered several issues with saving the dataset to a file.
After investigation I found that the source file has different vr that in dictionary And the main problem is that after the
naturalizeDataset
process we lose origin vr for these tags and in thedenaturalizeDataset
process we try to process tag with incorrect vrand therefore we get the following errors when trying to write.
In dicom image (LUTData tag has incorrect vr. In standart it US)
We received that image and we get the following errors when trying to write