-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBZ-6493: Initial implementation of Debezium Operator #1
Conversation
@jpechane So the changes discussed on the call should be in
For the default/automatic naming of predicates. I'm still not sure about it. You are right that the name is optional, however the predicate has to be referenced in transformation and I think explicit is better than implicit (guessing / researching the implicit naming) here. The default naming could be applied to transformations instead of predicates, however then the two will be different as one will be named implicitly and the other explicitly. |
@jcechace In that case predicates should not be list. It should be like
etc. WDYT? |
You mean? predicates:
pred0:
type: String
# other preticate property
pred1:
type: String
# other preticate property Sure, I don't have a strong prefference in this case (it probably does look a bit better (though it's a bit worse java wise as the "name" is pulled out into a map key instead of being part of the Predicate POJO). While we are at it. Wold you object if we also change a format a bit (to corespond to how we handle dynamic properties in So it would be predicates:
pred0:
type: String
config:
# other predicate property
pred1:
type: String
config:
# other predicate property The only thing I don't like is that here |
Maybe we can have both |
sure. Lets call it |
@jpechane BTW any objections against generalising the pattern where the dynamic properteis are placed under the format:
value:
type: String
config:
# other format properties or Transformers (which would also be changed to map from list) transforms:
trans0:
type: String
predicate: String
negate: Boolean
config:
# other transformation properties I'd like to be consistent with these |
…le to read confgmaps and secrets
… core code base and cleaned up ConfigMapping
@jpechane For now there is only a single PR workflow which doesn't pull any other repo for now. Building the server itself wouldn't help much -- we also need to build the DS container image and run the tests against a Kind cluster with this image loaded. I will eventually add all of it together with better testing, however it has to wait until after devconf. |
…e the value from parent
@jcechace Applied, thanks! |
No description provided.