DBZ-3226: Add step to verify the Debezium-server distribution #140
Conversation
| @@ -70,3 +70,45 @@ jobs: | |||
| run: ./server/mvnw clean install -f core/pom.xml -DskipTests -DskipITs -Dformat.formatter.goal=validate -Dformat.imports.goal=check -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 | |||
| - name: Maven build Debezium Server | |||
| run: ./server/mvnw clean install -fae -f server/pom.xml -Passembly -Dformat.formatter.goal=validate -Dformat.imports.goal=check -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 -DskipNonCore | |||
|
|
|||
| validate-distribution: | |||
There was a problem hiding this comment.
I think this job needs to be added also to the maven.yml, so I'm not sure why there are two files for building, so I prefer not duplicating it for now.
There was a problem hiding this comment.
@Sgitario One is executed on pull requests. That job migh need to build core not from the main branch but from a different branch (same name as this one). This is used for cases when PR depends on changes in core repo.
maven.yml is used exclusively for main/branch builds and always build from main of the core repo
Sgitario
force-pushed
the
DBZ-3226
branch
2 times, most recently
from
d1d9ddd to
b75af1b
Compare
| @@ -70,3 +70,53 @@ jobs: | |||
| run: ./server/mvnw clean install -f core/pom.xml -DskipTests -DskipITs -Dformat.formatter.goal=validate -Dformat.imports.goal=check -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 | |||
| - name: Maven build Debezium Server | |||
| run: ./server/mvnw clean install -fae -f server/pom.xml -Passembly -Dformat.formatter.goal=validate -Dformat.imports.goal=check -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 -DskipNonCore | |||
|
|
|||
| validate-distribution: | |||
There was a problem hiding this comment.
I wonder if a different job is needed as it executes yet another build. Can't the test be part of `build step?
There was a problem hiding this comment.
I wanted to have a different job to use the strategy.matrix, so we can execute the same job to cover other different sinks / configurations with little effort.
There was a problem hiding this comment.
Maybe the built artifact can be shared between jobs?
There was a problem hiding this comment.
I agree with Mario, if we can reuse the build across jobs since there is this build dependency defined, I think that's reasonable to reduce the overall execution time on CI.
| with: | ||
| distribution: 'temurin' | ||
| java-version: 21 | ||
| - name: Checkout Debezium Server repository |
There was a problem hiding this comment.
I think this is no more required right?
There was a problem hiding this comment.
Yes, to check out the sink specific test resources which is used to verify the server
There was a problem hiding this comment.
@Sgitario I think we've converged on good solution!
I left a comment WRT postgres exmaple version.
One mor eproposal for an imporvement - maybe a follow-up Jira. Would it be possible to connect to JMX as part of test evaluation and check metrics to make sure that expected number of messages was captured - effectivelly asserting https://debezium.io/documentation/reference/3.0/connectors/postgresql.html#connectors-snaps-metric-totalnumberofeventsseen_postgresql
debezium-server-dist/src/test/resources/redis/docker-compose.yml
Outdated
Show resolved
Hide resolved
This sounds good +1. I've just created https://issues.redhat.com/browse/DBZ-8518 to add this. Also, as a follow-up task and when this functionality is more consolidated, we should also add the rest of the sinks to it. @jpechane I've just squashed all the commits. |
|
@Sgitario Applied, thanks! |
Added a new job to validate the distribution works for each of the supported sinks. For now, I only added the "redis" sink.
Fixes https://issues.redhat.com/browse/DBZ-3226