DBZ-8302: Treat oracle negative timestamp values as -infinity. #5996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bue-von-hon <[email protected]> Co-authored-by: chungeun-choi <[email protected]> Co-authored-by: sean-k1 <[email protected]>
jpechane
requested changes
Nov 19, 2024
There was a problem hiding this comment.
@dongwook-chan Thanks for the PR. Could you please reformat the code so the tests are executed. lso could you please add a test case for the new feature? Thanks
debezium-connector-jdbc/pom.xml
Outdated
| @@ -202,6 +202,7 @@ | |||
| <dependency> | |||
| <groupId>com.oracle.database.jdbc</groupId> | |||
| <artifactId>ojdbc11</artifactId> | |||
| <version>23.6.0.24.10</version> | |||
There was a problem hiding this comment.
Why it is necessary to override the version here?
There was a problem hiding this comment.
Sorry, my bad! I removed the version tag.
There was a problem hiding this comment.
@jpechane
I also added config variable ORACLE_INFINITY_CONVERTER_ENABLE for the feature,
but have trouble accessing it from convertInfinityTimestampValue(). Could you give some advice on this? And I would like some advice on running integration test too.
Naros
reviewed
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were hoping to create a PR on this issue but found that the repo is archived.
Below is the PR that we attempted to create.
We want to refer to config from ZonedTimestampType.
But it takes a lot of depth to reach config from this class.
So we would you to provide some advice on this issue pls.
https://github.com/dongwook-chan/debezium-connector-jdbc/blob/2e2aa669c2a4f50ba85196d5cf8f4115a5155c28/src/main/java/io/debezium/connector/jdbc/dialect/mysql/ZonedTimestampType.java#L37-L39
We tried to run integration test on jdbc sink connector but failed.
So if you have any instructions on this please provide.