Introduce strum and strum_macros #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates. The purpose of these crates is to enable the usage of getting the variant counts and an iterator for the enumeration. Some documentation was added for enums and their functions. Added a basic README.md Bumped versions in Cargo.toml
ethteck
requested changes
Apr 2, 2024
This commit removes the implemented functions. Also updates the README.md description.
ethteck
approved these changes
Apr 3, 2024
AngheloAlf
reviewed
Apr 3, 2024
| @@ -0,0 +1,6 @@ | |||
| # pigment64 | |||
| pigment64 is a library written in Rust for converting image data between native and png formats. | |||
There was a problem hiding this comment.
"native" to who? I know it is meant to be as native to the n64, but I don't know if we want to restrict ourselves to only the n64
Comment on lines
+32
to
35
| /// # Panics | ||
| /// | ||
| /// This method will panic if the image size is invalid. | ||
| pub fn get_tlut_size(&self) -> usize { |
There was a problem hiding this comment.
I wonder if in the future we should change this to an Option or a Result instead of panicking. Out of scope for this PR, just writing down my thoughts
AngheloAlf
approved these changes
Apr 3, 2024
Didn't have auto-formatting on, this commit should fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the usage of the
strumandstrum_macroscrates. The purpose of these crates is to enable the usage of getting the variant counts and an iterator for the enumeration.Some documentation was added for enums and their functions.
Added a basic README.md
Bumped versions in Cargo.toml