Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Docs #79

Merged
merged 29 commits into from
Jul 9, 2024
Merged

Some Docs #79

merged 29 commits into from
Jul 9, 2024

Conversation

hensldm
Copy link
Contributor

@hensldm hensldm commented Jun 21, 2024

Port over some documentation (function/file headers and comments) from the zelda64 code bases. Also does some general cleanup.

hensldm and others added 27 commits June 21, 2024 15:11
Co-authored-by: Tharo <[email protected]>
Co-authored-by: Tharo <[email protected]>
Co-authored-by: Tharo <[email protected]>
Co-authored-by: Tharo <[email protected]>
Co-authored-by: Tharo <[email protected]>
Co-authored-by: Tharo <[email protected]>
Co-authored-by: Tharo <[email protected]>
Co-authored-by: Tharo <[email protected]>
Co-authored-by: EllipticEllipsis <[email protected]>
Co-authored-by: engineer124 <[email protected]>
Co-authored-by: EllipticEllipsis <[email protected]>
Co-authored-by: engineer124 <[email protected]>
Co-authored-by: EllipticEllipsis <[email protected]>
Co-authored-by: engineer124 <[email protected]>
Co-authored-by: Tharo <[email protected]>
Copy link
Collaborator

@Thar0 Thar0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little things

src/os/probetlb.s Outdated Show resolved Hide resolved
src/os/exceptasm.s Outdated Show resolved Hide resolved
src/os/exceptasm.s Outdated Show resolved Hide resolved
Co-authored-by: Tharo <[email protected]>
src/os/invaldcache.s Outdated Show resolved Hide resolved
Copy link
Collaborator

@AngheloAlf AngheloAlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit, everything else looks fine to my non-expert eye

mfc0 t3, C0_PAGEMASK
addi t3, t3, DCACHE_SIZE
addi t3, t3, 0x2000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional? At first glance it seems like a regression

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it was intentional. See #79 (comment)

@hensldm hensldm merged commit 52d323d into decompals:main Jul 9, 2024
20 checks passed
@hensldm hensldm deleted the docs branch July 9, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants