-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Docs #79
Some Docs #79
Conversation
Co-authored-by: Tharo <[email protected]>
Co-authored-by: Tharo <[email protected]>
Co-authored-by: Tharo <[email protected]>
Co-authored-by: Tharo <[email protected]>
Co-authored-by: Tharo <[email protected]>
Co-authored-by: Tharo <[email protected]>
Co-authored-by: Tharo <[email protected]>
Co-authored-by: Tharo <[email protected]>
Co-authored-by: EllipticEllipsis <[email protected]> Co-authored-by: engineer124 <[email protected]>
Co-authored-by: EllipticEllipsis <[email protected]> Co-authored-by: engineer124 <[email protected]>
Co-authored-by: EllipticEllipsis <[email protected]> Co-authored-by: engineer124 <[email protected]>
Co-authored-by: Tharo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little things
Co-authored-by: Tharo <[email protected]>
Co-authored-by: Tharo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a nit, everything else looks fine to my non-expert eye
mfc0 t3, C0_PAGEMASK | ||
addi t3, t3, DCACHE_SIZE | ||
addi t3, t3, 0x2000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional? At first glance it seems like a regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it was intentional. See #79 (comment)
Port over some documentation (function/file headers and comments) from the zelda64 code bases. Also does some general cleanup.