New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressed `cancelOrders` reentrancy #1229

Open

jalextowle wants to merge 1 commit into jalextowle/fix/matching-engine-frontrunning from jalextowle/fix/matching-engine-cancel-orders-reentrancy

Contributor

jalextowle commented Dec 17, 2024

Description

Added a reentrancy guard to cancelOrders.


          Added a non-reentrancy modifier to cancelOrders

50cb181

jalextowle requested review from jrhea, mcclurejt, dpaiton and slundqui as code owners

December 17, 2024 05:54

Sean329 commented Dec 17, 2024

lgtm

Collaborator

coveralls commented Dec 17, 2024

Pull Request Test Coverage Report for Build 12367227605

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.29%

Totals
Change from base Build 12361837408:	0.0%
Covered Lines:	2868
Relevant Lines:	3212

💛 - Coveralls

mcclurejt approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcclurejt mcclurejt approved these changes

jrhea Awaiting requested review from jrhea jrhea is a code owner

dpaiton Awaiting requested review from dpaiton dpaiton is a code owner

slundqui Awaiting requested review from slundqui slundqui is a code owner

Labels

None yet