Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add documentation build GHA workflow file #57

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

jhlegarreta
Copy link
Contributor

@jhlegarreta jhlegarreta commented Dec 3, 2024

  • ENH: Add documentation build GHA workflow file
  • BUG: Make the documentation config file latex_preamble be a literal
  • BUG: Provide a class name to the Sphinx lexer

@jhlegarreta jhlegarreta force-pushed the AddDocBuildGHAWorkflow branch from e29e04d to c77c7c2 Compare December 5, 2024 00:09
Add documentation build GHA workflow file.
@jhlegarreta jhlegarreta force-pushed the AddDocBuildGHAWorkflow branch from c77c7c2 to c444f69 Compare December 5, 2024 00:16
Make the documentation config file `latex_preamble` be a literal string:
add the `r` prefix.

Fixes:
```
  File "/home/runner/work/tract_querier/tract_querier/doc/conf.py", line 229
    """
       ^
SyntaxError: (unicode error) 'unicodeescape' codec can't decode bytes in position 1-2: truncated \uXXXX escape
```

raised for example at:
https://github.com/demianw/tract_querier/actions/runs/12170692299/job/33946161700#step:4:15
Provide a class name to the `Sphinx` lexer: the `add_lexer` method does
not accept lexer instances as an argument since version 4.0.

Fixes:
```
Exception occurred:
  File ".virtualenvs/tract_querier/lib/python3.10/site-packages/sphinx/highlighting.py", line 159, in get_lexer
    lexer = lexer_classes[lang](**opts)
TypeError: 'WMQLLexer' object is not callable
```

raised in a local build with Python 3.10 and Sphinx 8.1.3.

Documentation:
https://www.sphinx-doc.org/en/master/extdev/appapi.html#sphinx.application.Sphinx.add_lexer
@jhlegarreta
Copy link
Contributor Author

jhlegarreta commented Dec 5, 2024

Docs are being built locally: build failures are related to NumPy being too old:
https://github.com/demianw/tract_querier/actions/runs/12170996001/job/33947073264?pr=57

PR #58 will resolve that.

@jhlegarreta
Copy link
Contributor Author

Doc build warnings will be addressed as time permits.

@jhlegarreta jhlegarreta marked this pull request as ready for review December 5, 2024 00:45
@demianw demianw merged commit f252205 into demianw:master Dec 5, 2024
0 of 9 checks passed
@jhlegarreta jhlegarreta deleted the AddDocBuildGHAWorkflow branch December 5, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants