Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed test_query_eval to use pytest fixtures #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed test_query_eval to use pytest fixtures #74

wants to merge 1 commit into from

Conversation

demianw
Copy link
Owner

@demianw demianw commented Dec 11, 2024

addressing issue #69

@demianw
Copy link
Owner Author

demianw commented Dec 11, 2024

@jhlegarreta do you want to check this PR fixing the test issue #69 ?

@jhlegarreta
Copy link
Contributor

@demianw I have checkout the branch and ran ppytest on the file 100 times 4 times using the pytest-repeat package; first time all passed, next three times, it failed:

Passed:

Failed:

Failed:

So the change does not fix the issue. Feel free to merge it if you believe it constitutes an improvement anyways or if you think it will allow debugging this better.

@demianw
Copy link
Owner Author

demianw commented Dec 11, 2024 •
edited
Loading

Thanks for the insight. I will test with pytest-repeat as you recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demianw @jhlegarreta