Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendors-sdk - Update the packages #34776

Conversation

briluza
Copy link

@briluza briluza commented Dec 19, 2024

Status

Ready

Related Content Pull Request

Related PR: link to the PR at demisto/content

Related Issues

Related: #34782

Description

updated poetry.lock file for docker/vendors-sdk to get the latest version of domaintools-api

Copy link

welcome bot commented Dec 19, 2024

Thanks for opening your first pull request. You are awesome!

Questions about how we build Docker images? Make sure to checkout our README.

What happens next?

  • The CI will run the build cycle on any new/modified docker images. If the build fails make sure to review the posted comment and address the errors.
  • Once the build passes, The CI will create a development docker image which can be used for local testing. A comment with the details will be posted to this PR.
  • A member of the team will then review the pull request.
  • If all is good and both the build is passing and the pull request has passed review, you will be able to merge the PR.
  • Once merged, The CI will run another build and create a production ready docker image which will be deployed at Docker Hub under the demisto organization: https://hub.docker.com/u/demisto .

Good luck to us all!

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@samuelFain samuelFain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @briluza and thank you for your contribution!
A few notes:

  • Please add a description of what is purpose of this PR, what is changed and why.
  • I see that only the docker/vendors-sdk/poetry.lock file has changed in this PR. However, changes to the poetry.lock file typically result from modifications to the pyproject.toml file, followed by running a command like poetry lock. I feel like the changes to the pyproject.toml are missing in this PR, unless this was intentional and the aim was to generally update the dependencies of this docker image. Please let me know if I am misunderstanding your intentions.
  • Generally, contributions to the dockerfiles repository are accompanied by a corresponding PR in the content repository. While this is not mandatory, if there is a related PR in the content repository, please let me know about it.

@briluza
Copy link
Author

briluza commented Dec 23, 2024

Hi @samuelFain,

thank you for the quick response, in this PR I only update the poetry.lock as mostly the packages (including the domaintools-api) has the version in the pyproject.toml is set to * , I think I just need to update the lock file and not the toml file to update the packages/dependencies. (correct me if I'm wrong)

  • for the PR related, as of the moment No we haven't raised the PR in the content repo as it's still in progress and this package update is needed so we can test it in our dev and staging environment.

Let me know if I missed something or I need to change anything. Thank you!

@samuelFain
Copy link
Contributor

@briluza Everything looks good to me then.
Just a quick note: due to a technical issue we are currently experiencing, the
ci/gitlab/gitlab.xdr.pan.local and native_docker_image_labeled GitHub actions cannot run on a contribution PR to the dockerfiles repository - like this one. This is a merge blocker.
To save us all the waiting time, I went ahead and opened an internal PR with the changes of this PR so I can merge it.
This will mean that I'll merge the internal PR with the changes from this PR instead of merging this PR.
Please let me know if you are OK with this action, and if you do, please verify the changes in #34782 and let me know we are good-to-merge.

@briluza
Copy link
Author

briluza commented Dec 24, 2024

I checked and verify that the changes in poetry.lock also updates the domaintools-api package in the latest version. Thank you!

@samuelFain
Copy link
Contributor

Internal PR merged. Closing this PR.

@samuelFain samuelFain closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants