-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendors-sdk - Update the packages #34776
vendors-sdk - Update the packages #34776
Conversation
Thanks for opening your first pull request. You are awesome! Questions about how we build Docker images? Make sure to checkout our README. What happens next?
Good luck to us all! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @briluza and thank you for your contribution!
A few notes:
- Please add a description of what is purpose of this PR, what is changed and why.
- I see that only the
docker/vendors-sdk/poetry.lock
file has changed in this PR. However, changes to the poetry.lock file typically result from modifications to thepyproject.toml
file, followed by running a command likepoetry lock
. I feel like the changes to the pyproject.toml are missing in this PR, unless this was intentional and the aim was to generally update the dependencies of this docker image. Please let me know if I am misunderstanding your intentions. - Generally, contributions to the dockerfiles repository are accompanied by a corresponding PR in the content repository. While this is not mandatory, if there is a related PR in the content repository, please let me know about it.
Hi @samuelFain, thank you for the quick response, in this PR I only update the
Let me know if I missed something or I need to change anything. Thank you! |
@briluza Everything looks good to me then. |
I checked and verify that the changes in poetry.lock also updates the |
Internal PR merged. Closing this PR. |
Status
Ready
Related Content Pull Request
Related PR: link to the PR at demisto/content
Related Issues
Related: #34782
Description
updated
poetry.lock
file fordocker/vendors-sdk
to get the latest version ofdomaintools-api