perf(ext/webstorage): use object wrap for Storage
#26931
Draft
+137
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
changed the title
littledivy
changed the title
Storage
littledivy
changed the title
StorageStorage
littledivy
commented
Nov 23, 2024
Comment on lines
+228
to
+243
| #[method] | ||
| #[serde] | ||
| fn iterate_keys( | ||
| &self, | ||
| state: &mut OpState, | ||
| ) -> Result<Vec<String>, WebStorageError> { | ||
| let conn = get_webstorage(state, self.persistent)?; | ||
|
|
||
| let mut stmt = conn.prepare_cached("SELECT key FROM data")?; | ||
| let keys = stmt | ||
| .query_map(params![], |row| row.get::<_, String>(0))? | ||
| .map(|r| r.unwrap()) | ||
| .collect(); | ||
|
|
||
| Ok(keys) | ||
| } |
There was a problem hiding this comment.
todo: make this private or keep it as a normal op
littledivy
commented
Nov 23, 2024
| @@ -9789,7 +9789,7 @@ | |||
| "event_constructor.window.html": false, | |||
| "event_initstorageevent.window.html": false, | |||
| "missing_arguments.window.html": true, | |||
| "storage_builtins.window.html": true, | |||
| "storage_builtins.window.html": false, | |||
There was a problem hiding this comment.
This test checks if
Storage.prototype.setItem == localStorage.setItem
but our Proxy needs to create a new instance via .bind because receiver holds cppgc object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
#[required(<count>)]deno_core#976String(V)for non-strings deno_core#980