Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(check): compiler options from workspace members #27009

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(check): compiler options from workspace members #27009

wants to merge 2 commits into from

Conversation

nayeemrmn
Copy link
Collaborator

Very blunt first draft.

TODO: Add needed deno_config APIs, currently using hacks but it works.

dsherret
dsherret reviewed Nov 23, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Add needed deno_config APIs, currently using hacks but it works.

Considering the 2.1 release passed, maybe let's spend the time to do this right before merging?

@nayeemrmn
Copy link
Collaborator Author

Yeah this is not for landing yet

@nayeemrmn nayeemrmn marked this pull request as draft November 23, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nayeemrmn @dsherret