-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(uuid/unstable): @std/uuid/v7
#5887
Conversation
e58b032
to
5382a7b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5887 +/- ##
=======================================
Coverage 96.32% 96.33%
=======================================
Files 483 484 +1
Lines 39064 39116 +52
Branches 5731 5733 +2
=======================================
+ Hits 37630 37681 +51
- Misses 1390 1391 +1
Partials 44 44 ☔ View full report in Codecov by Sentry. |
5382a7b
to
d80bb5b
Compare
Should we consider supporting monotonicity? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanly done so far! Nice. Few concerns.
I intentionally left out the optional features, these could be added in a seperate pr as an option, for this pr I would like to start with the basic implementation
|
@std/uuid/v7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only one idea for generate()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM again. Again, good work!
Adds UUID Version 7 support.
This variant provides solution for scenarios requiring both uniqueness and chronological ordering.
The same pattern as other uuid generation has been used.
I have not included the optional features for sub-millisecond timestamp fraction or carefully seeded counter