fix(tar): untar checksum calculation for the pax format #6199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6199 +/- ##
=======================================
Coverage 96.52% 96.53%
=======================================
Files 533 533
Lines 40871 40871
Branches 6120 6120
=======================================
+ Hits 39451 39455 +4
+ Misses 1378 1374 -4
Partials 42 42 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
BlackAsLight
changed the title
|
Could you add a test case for this fix? |
kt3k
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
I also confirmed the example archives https://github.com/polyseam/cndi/releases/download/v2.20.0/cndi-mac.tar.gz and https://github.com/themesberg/flowbite-icons/archive/refs/tags/v1.3.0.tar.gz can be extracted with this change. Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6083
After further investigation it seems the problem tarball was using 7 octal digits to encode the checksum instead of 6, like the spec this implementation is based off says to use. Other tar specs don't seem to make any comment on only using 6 octal digits. So for more flexibility this spec just parses the entire 8 bytes instead of the first 6.