Submit action for 'No Errors Found' modal #23636
Conversation
app/controllers/tasks_controller.rb
Outdated
| @@ -187,6 +187,37 @@ def request_hearing_disposition_change | |||
| end | |||
|
|
|||
| def upload_transcription_to_vbms | |||
| file_paths = ReviewTranscriptTask.find_by(id: task.id).appeal.hearings.first.transcription_files | |||
There was a problem hiding this comment.
Change ReviewTranscriptTask.find_by(task.id)... to task
You already have the task - you do not need to query the db again using the id of the task you have already fetched.
There was a problem hiding this comment.
@mchbidwell Getting from ReviewTranscriptTask to TranscriptionFile seems prone to wackiness - tasks -> appeals -> hearings (could be multiple hearings for an appeal) -> transcription_files
In the implementation here, we're arbitrarily grabbing .first
|
|
||
| private | ||
|
|
||
| def create_document_params(appeal, file_name, current_file_path) |
There was a problem hiding this comment.
This seems like it may need to belong in another class - probably not the responsibility of TasksController
app/controllers/tasks_controller.rb
Outdated
| file_paths = ReviewTranscriptTask.find_by(id: task.id).appeal.hearings.first.transcription_files | ||
| .where(file_type: "pdf").map(&:fetch_file_from_s3!) | ||
|
|
||
| appeal = ReviewTranscriptTask.find_by(id: task.id).appeal |
There was a problem hiding this comment.
Again ReviewTranscriptTask.find_by(id: task.id) can just be task
Resolves APPEALS-64077
Description
As a Caseflow User I need the ability to upload the "final PDF" to the selected Appellants eFolder endpoint in VBMS so that files can be retrieved when needed.
As a Caseflow Developer I need to;
Create a new method on submit for 'No Errors Found'
1- DocketNumber_interenalHearingID_HearingClassName.pdf
2- Upload the PDF file to the Appellants eFolder location in VBMS
Acceptance Criteria
Testing Plan
Frontend
Hearing Admin Team casesNo errors found: Upload transcript to VBMSUpload to VBMSTests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?