Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Indicator for First Notice of Death #23639

Open
wants to merge 4 commits into
base: feature/APPEALS-57706
Choose a base branch
from

Conversation

prernadevbah
Copy link
Contributor

Resolves Add Indicator for First Notice of Death (FNOD)

Description

Added a new migration to update the NationalHearingQueueEntry materialized view with a veteran_deceased_idicator column.
Added tests

Acceptance Criteria

  • Code compiles correctly
  • A migration is created to introduce the following column to the national_hearing_queue_entries materialized view for both types of appeals:
    • veteran_deceased_indicator
      • True if:
        • AMA Appeal:
          • Source: veterans.date_of_death is non-null
        • Legacy Appeal:
          • Source f_vacols_corres.sfnod is non-null
      • False otherwise

Testing Plan

  1. Go to APPEALS-66314

Backend

Database Changes

Only for Schema Changes

  • Add typical timestamps (created_at, updated_at) for new tables
  • Update column comments; include a "PII" prefix to indicate definite or potential PII data content
  • Have your migration classes inherit from Caseflow::Migration, especially when adding indexes (use add_safe_index) (see Writing DB migrations)
  • Verify that migrate:rollback works as desired (change supported functions)
  • Perform query profiling (eyeball Rails log, check bullet and fasterer output)
  • For queries using raw sql was an explain plan run by System Team
  • Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
  • Run make check-fks; add any missing foreign keys or add to config/initializers/immigrant.rb (see Record associations and Foreign Keys)
  • Add belongs_to for associations to enable the schema diagrams to be automatically updated
  • Document any non-obvious semantics or logic useful for interpreting database data at Caseflow Data Model and Dictionary

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant