Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

96963 Update form1010d flipper actor type to cookie_id - form 10-10d #19639

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michaelclement
Copy link
Contributor

@michaelclement michaelclement commented Nov 27, 2024

Summary

Updates the flipper type to be cookie_id rather than user. Using cookie_id as it should provide a more consistent experience for any users who are allowed to see the content behind the toggle in any of the multiple locations on va.gov where it is used.

  • Updated flipper actor type

Related issue(s)

Testing done

  • Manual

Screenshots

NA

What areas of the site does it impact?

This form only

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

NA

@va-vfs-bot va-vfs-bot temporarily deployed to 96963-update-form1010d-flipper-actor-type/main/main November 27, 2024 15:02 Inactive
Copy link

Backend-review-group approval confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants