Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHV-44894 Corrected function call #19643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmoyer-va
Copy link
Contributor

@mmoyer-va mmoyer-va commented Nov 27, 2024

Summary

  • Corrected a very small mistake in the controller code for images. It was calling the wrong function.

Related issue(s)

  • This is related to the MHV-44894 imaging work but this PR is just to correct a small mistake that was made during API creation.

Testing done

  • Discovered the mistake during manual testing. Verified the fix by the same method.

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Copy link
Contributor

@mattwrightva mattwrightva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mmoyer-va mmoyer-va marked this pull request as ready for review November 27, 2024 19:00
@mmoyer-va mmoyer-va requested review from a team as code owners November 27, 2024 19:00
Copy link

Backend-review-group approval confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants