Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 42872 coutry to coutrycode poa v2 #19650

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rockwellwindsor-va
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va commented Nov 27, 2024

Summary

  • Updates country => countryCode in 2122 and 2122a schemas
    • Updates REGEX in schema pattern to only allow 2 characters, matches the current stateCode REGEX
  • Adjusts related tests
  • Updates swagger documentation to reflect change

Related issue(s)

API-42872

Testing done

  • Updates made to existing tests for change

Screenshots

Screenshot 2024-11-27 at 2 07 56 PM

Screenshot 2024-11-27 at 2 08 05 PM

Screenshot 2024-11-27 at 2 08 41 PM

What areas of the site does it impact?

modified:   modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
modified:   modules/claims_api/app/swagger/claims_api/v2/production/swagger.json
modified:   modules/claims_api/spec/requests/v2/veterans/rswag_power_of_attorney_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

* Updates `country` => `countryCode` in 2122 and 2122a schemas
* Adjusts related tests
* Updates swagger documentation to reflect change
	modified:   modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
	modified:   modules/claims_api/app/swagger/claims_api/v2/production/swagger.json
	modified:   modules/claims_api/spec/requests/v2/veterans/rswag_power_of_attorney_spec.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants