Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 support for Git for Windows and update to 2.47.1 #515

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dennisameling
Copy link
Contributor

Git for Windows added support for arm64 releases in their 2.47.1 version. Let's add support for it in the update-git.ts script.

I also ran the update-git.ts script after adding this change, which correctly added the arm64 version of Git to dependencies.json. I'll leave it up to you if you also want to include that commit already, or if you want to address the version bump separately.

Ref: https://github.com/git-for-windows/git/releases/tag/v2.47.1.windows.1
Ref: git-for-windows/git#3107 (comment)

@dennisameling dennisameling marked this pull request as draft November 26, 2024 14:01
dennisameling and others added 4 commits November 26, 2024 15:02
Git for Windows added support for arm64 releases in their 2.47.1 version. Let's add support for it in the `update-git.ts` script.

Ref: https://github.com/git-for-windows/git/releases/tag/v2.47.1.windows.1
Ref: git-for-windows/git#3107 (comment)
Signed-off-by: Dennis Ameling <[email protected]>
This updates Git by running the `update-git.ts` script, which automatically added the arm64 version of Git as well.

Signed-off-by: Dennis Ameling <[email protected]>
Git LFS has supported Windows arm64 since 2021. Let's add it to the dependencies, now that Git itself also support it.

Ref: git-lfs/git-lfs#4586
Signed-off-by: Dennis Ameling <[email protected]>
Now that the update-git-lfs.ts script has been updated to include Windows arm64 binaries, running `npm run update-git-lfs` automatically added the Windows arm64 binary to `dependencies.json`.

Signed-off-by: Dennis Ameling <[email protected]>
@dennisameling dennisameling force-pushed the git-arm64-support branch 2 times, most recently from e63c685 to 15c67ff Compare November 26, 2024 14:28
Now that we're getting native arm64 binaries for both Git and Git LFS, we can start leveraging them in the `build-win32.sh` script.

Signed-off-by: Dennis Ameling <[email protected]>
Now that Windows arm64 is also supported, we can add it to CI and simplify the pipeline while at it.

Signed-off-by: Dennis Ameling <[email protected]>
@dennisameling dennisameling marked this pull request as ready for review November 26, 2024 14:34
@dennisameling
Copy link
Contributor Author

@sergiou87 @niik @tidy-dev this might be of interest to y'all 😊

@sergiou87
Copy link
Member

You are the best @dennisameling 🥹🥹🥹🥹🥹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants