-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arm64 support for Git for Windows and update to 2.47.1 #515
Open
dennisameling
wants to merge
6
commits into
desktop:master
Choose a base branch
from
dennisameling:git-arm64-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Git for Windows added support for arm64 releases in their 2.47.1 version. Let's add support for it in the `update-git.ts` script. Ref: https://github.com/git-for-windows/git/releases/tag/v2.47.1.windows.1 Ref: git-for-windows/git#3107 (comment) Signed-off-by: Dennis Ameling <[email protected]>
This updates Git by running the `update-git.ts` script, which automatically added the arm64 version of Git as well. Signed-off-by: Dennis Ameling <[email protected]>
Git LFS has supported Windows arm64 since 2021. Let's add it to the dependencies, now that Git itself also support it. Ref: git-lfs/git-lfs#4586 Signed-off-by: Dennis Ameling <[email protected]>
Now that the update-git-lfs.ts script has been updated to include Windows arm64 binaries, running `npm run update-git-lfs` automatically added the Windows arm64 binary to `dependencies.json`. Signed-off-by: Dennis Ameling <[email protected]>
dennisameling
force-pushed
the
git-arm64-support
branch
2 times, most recently
from
November 26, 2024 14:28
e63c685
to
15c67ff
Compare
Now that we're getting native arm64 binaries for both Git and Git LFS, we can start leveraging them in the `build-win32.sh` script. Signed-off-by: Dennis Ameling <[email protected]>
Now that Windows arm64 is also supported, we can add it to CI and simplify the pipeline while at it. Signed-off-by: Dennis Ameling <[email protected]>
dennisameling
force-pushed
the
git-arm64-support
branch
from
November 26, 2024 14:34
15c67ff
to
23d6d13
Compare
@sergiou87 @niik @tidy-dev this might be of interest to y'all 😊 |
You are the best @dennisameling 🥹🥹🥹🥹🥹 |
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git for Windows added support for arm64 releases in their 2.47.1 version. Let's add support for it in the
update-git.ts
script.I also ran the
update-git.ts
script after adding this change, which correctly added the arm64 version of Git todependencies.json
. I'll leave it up to you if you also want to include that commit already, or if you want to address the version bump separately.Ref: https://github.com/git-for-windows/git/releases/tag/v2.47.1.windows.1
Ref: git-for-windows/git#3107 (comment)