This repository has been archived by the owner on Oct 29, 2022. It is now read-only.
Apply highlighting changes immediately #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is deprecated by #114 now |
sztanpet
pushed a commit
that referenced
this pull request
Aug 8, 2016
* Apply highlighting changes immediately * Mark nicks in the backlog as clickable * Fix scoping issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt to do something useful, this is supposed to fix #112.
It should be considered to make a distinction between different highlight-types. This patch would introduce a "bug" because all highlights are currently equal:
If a user mentions you by nick, and you "/unhighlight" them afterwards, that message will get unhighlighted as well, even though messages that include your nick would be highlighted regardless of highlight-preference.