Skip to content

Commit

Permalink
Disable certificate check for app download files as long as we have a…
Browse files Browse the repository at this point in the history
…n old electron version due to electron-builder, see comment.
  • Loading branch information
carlkuesters committed Oct 7, 2021
1 parent 6722c5a commit 7496d24
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "destrostudios",
"version": "1.1.5",
"version": "1.1.6",
"description": "destrostudios cross-game launcher, offering the possibility to login, download, update and start games.",
"author": "destrostudios",
"license": "MIT",
Expand Down
4 changes: 3 additions & 1 deletion src/main/local-apps.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ function downloadFile(url, destination, downloadedBytesCallback, finishedCallbac
createDirectoryIfNotExisting(destination);
const file = fs.createWriteStream(destination);
console.log('Downloading file: "' + url + '" --> "' + destination + '"');
https.get(url, response => {
// FIXME: LetsEncrypt deprecated their old root certificate (https://letsencrypt.org/docs/dst-root-ca-x3-expiration-september-2021)
// The currently used electron-builder version still has an old electron dependency of 11.X - When we have 13.X with the fix, the rejectUnauthorized workaround can be removed
https.get(url, { rejectUnauthorized: false }, response => {
response.on('data', chunk => {
file.write(chunk);
downloadedBytesCallback(chunk.length);
Expand Down
2 changes: 1 addition & 1 deletion src/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "destrostudios",
"version": "1.1.5",
"version": "1.1.6",
"description": "Destrostudios cross-game launcher, offering the possibility to login, download, update and start games.",
"author": "destrostudios",
"main": "electron-main.js",
Expand Down

0 comments on commit 7496d24

Please sign in to comment.