Added ability to append The number of players online to server username #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about using the server queries for the player count? There are libs for it available, and even a web based API: https://mcapi.us |
|
@destruc7i0n At least check out my regex improvements in #54 while I actually implement something more production ready. I have a few other features i want to implement and honestly getting server queries working would make our lives easier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on 2 x 24/7 servers
Does not conflict with pull request #54
Details
Added ability to append the number of users currently in the server to the server username.
Online player count is still tracked and show correctly on other server notifications when SHOW_PLAYER_CONN_STAT is set to false as long as PLAYERCOUNT_IN_SERVERNAME is enabled. This is used for the circumstances where player count is desired to be part of the server username but join and leave notifications are not.
Added escape-string-regexp library to help sanitize variables. Used in the function that selects correct Avatar URL. This also improves the original way of detecting whether the username was the server name because as long as the username has "ServerName - Server" somewhere in it, it picks the server Avatar URL. Allowing future items to be appended on the server username without affecting detection.