patches/patch0.txt: fix build on -fno-common toolchains #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On gcc-10 (and gcc-9 -fno-common) sasquatch build fails as:
c++ ./LZMA/lzmalt/*.o unsquashfs.o ... -o sasquatch
ld: unsquash-1.o:squashfs-tools/error.h:34:
multiple definition of `verbose'; unsquashfs.o:squashfs-tools/error.h:34: first defined here
gcc-10 will changed the default from -fcommon to fno-common:
https://gcc.gnu.org/PR85678.
The change splits declaration and definition.
trofi
added a commit
to trofi/nixpkgs
that referenced
this pull request
Nov 27, 2021
Without the change build on clang-12 or upstream gcc-12 fails as:
$ nix build --impure --expr 'with import ./. {}; sasquatch.override { stdenv = clang12Stdenv; }' -L
...
c++ ./LZMA/lzmalt/*.o ... -o sasquatch
ld: squashfs-tools/./error.h:34: multiple definition of `verbose'; unsquashfs.o:error.h:34: first defined here
Until upstrea fixes it by fixing `verbose` variable declaration at:
devttys0/sasquatch#44
and fork rebases let's set `-fcommon` explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On gcc-10 (and gcc-9 -fno-common) sasquatch build fails as:
gcc-10 will changed the default from -fcommon to fno-common:
https://gcc.gnu.org/PR85678.
The change splits declaration and definition.