Implement the Locale claim for the OIDC connector #1535
Conversation
|
💯 Thank you for contributing! I've not reviewed this thoroughly yet, just pointed out one thing amiss wrt. migrations. I'll try to review this soon. |
justin-slowik
force-pushed
the
Enable_Locale
branch
from
b72aaf3 to
f565bc4
Compare
|
Hi @srenatus , I was just curious if you've had a chance to take another look at this PR since I addressed your comments. Would love to get this in and then I could get working on zoneinfo next. Thanks! |
Modified Conformance unit tests to not have Locale in secondary use cases. Removed the "not null default '' " from the migrate statements.
|
@srenatus in each of the conformance tests that utilize claims (testAuthCodeCRUD, testAuthRequestCRUD, and testRefreshTokenCRUD), I removed the locale claim from the secondary creates for each (a2 / refresh2 respectively) and verified that the tests still passed successfully. Long term it may be worth making a test / tests that exercises all claims one at a time to be more complete, but i think thats out of the scope of this PR. |
justin-slowik
changed the title
justin-slowik
force-pushed
the
Enable_Locale
branch
from
8ecc73a to
bdfdc18
Compare
justin-slowik
changed the title
|
@srenatus Ignore my last comment/commit (since deleted and reverted). Accidentally pushed to the wrong branch. Anything else that needs to be done here? |
|
@justin-slowik I'd hope @JoelSpeed or @bonifaido would pick up reviewing and merging this. I have no bandwidth left at the moment, I'm afraid. (I could merge this, but I cannot find time to deal with any fallout, so I cannot actually merge this 😅) |
the .well-known/openid-configuration return of Dex was displaying that "locale" was a supported claim when in fact it was not. My project requires locale, so I implemented the claim for the OIDC Connector and Storage methods.
This is my first deep dive into Go so please let me know if i missed anything