chore(crypto): Clean up BIP340 signature processing #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A somewhat confusing k256 API led me to believe it did not correctly handle the situation where the y coordinate of the public key was odd. This is not the case, and the code to explicitly flip the public or private keys during signature generation/verification is not required.
randombit
changed the title
altkdf
approved these changes
Aug 30, 2024
fspreiss
reviewed
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A somewhat confusing k256 API led me to believe it did not correctly handle the situation where the y coordinate of the public key was odd. This is not the case, and the code to explicitly flip the public or private keys during signature generation/verification is not required.