Skip to content

Commit

Permalink
chore: self-closing HTML tags for non-void elements are ambiguous (#6022
Browse files Browse the repository at this point in the history
)

# Motivation

Fix warning which becomes an error with Svelte v5 tooling (PR #6020).

```
  19:5  error  Self-closing HTML tags for non-void elements are ambiguous — use `<div ...></div>` rather than `<div ... />`
https://svelte.dev/e/element_invalid_self_closing_tag(element_invalid_self_closing_tag)  svelte/valid-compile
```

# Changes

- e.g. `<div />` -> `<div></div>`

Signed-off-by: David Dal Busco <[email protected]>
  • Loading branch information
peterpeterparker authored Dec 17, 2024
1 parent c165a28 commit 8622776
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
{/if}
</TooltipIcon>
</div>
<div class="vertical-divider" />
<div class="vertical-divider"></div>
{/if}<div class="account-name">
{accountName}
</div>
Expand Down
10 changes: 5 additions & 5 deletions frontend/src/lib/components/common/EmptyCards.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,19 @@

<div class="card-grid" data-tid="empty-cards-component">
<Card disabled>
<div class="card-item" />
<div class="card-item"></div>
</Card>
<Card disabled>
<div class="card-item" />
<div class="card-item"></div>
</Card>
<Card disabled>
<div class="card-item" />
<div class="card-item"></div>
</Card>
<Card disabled>
<div class="card-item" />
<div class="card-item"></div>
</Card>
<Card disabled>
<div class="card-item" />
<div class="card-item"></div>
</Card>
</div>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
class="min-indicator"
data-tid="commitment-min-indicator"
style={`left: calc(${minIndicatorPosition}px);`}
/>
></span>
</div>
</div>
{/if}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/lib/components/ui/ProposalStatusTag.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
class="actionable-status-badge"
role="status"
transition:scale={{ duration: 250, easing: cubicOut }}
/>
></div>
</Tooltip>
</div>
{/if}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@
ledgerCanisterId={CKTESTBTC_LEDGER_CANISTER_ID}
{reload}
>
<div data-tid="test-observer" />
<div data-tid="test-observer"></div>
</IcrcBalancesObserver>
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@
ledgerCanisterId={CKTESTBTC_LEDGER_CANISTER_ID}
indexCanisterId={CKTESTBTC_INDEX_CANISTER_ID}
>
<div data-tid="test-observer" />
<div data-tid="test-observer"></div>
</IcrcWalletTransactionsObserver>
2 changes: 1 addition & 1 deletion frontend/src/tests/lib/directives/IntersectionTest.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
import { onIntersection } from "$lib/directives/intersection.directives";
</script>

<div use:onIntersection />
<div use:onIntersection></div>

0 comments on commit 8622776

Please sign in to comment.