Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove ic-admin and sns from scripts/setup (#5425)
# Motivation One of the first things people do when developing on nns-dapp is running `scripts/setup`. This installs (among other things) `ic-admin` and `sns`. But you need to set `IC_COMMIT` to be able to do this, and there is no good way in the nns-dapp repo to get it. The `bin/dfx-sns-demo-install` in `snsdemo` also [installs these tools](https://github.com/dfinity/snsdemo/blob/fdaf0fb392a88880c93a589f096957680acac523/bin/dfx-sns-demo-install#L29) and has the `IC_COMMIT` [configured in the repo](https://github.com/dfinity/snsdemo/blob/fdaf0fb392a88880c93a589f096957680acac523/bin/versions.bash#L5) and [updated periodically](https://github.com/dfinity/snsdemo/blob/main/.github/workflows/update-ic.yml). So let's just remove `ic-admin` and `sns` from `scripts/setup`. # Changes Removed installing `ic-admin` and `sns` from `scripts/setup`. # Tests Manually ran `scripts/setup` and checked that it no longer tries to install (or checks presence of) `ic-admin` and `sns`. # Todos - [ ] Add entry to changelog (if necessary). not necessary
- Loading branch information