Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait longer for docker to start up in workflow/reproducible.yaml. #4574

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/reproducible.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,15 @@ jobs:
echo "/usr/local/bin" >> $GITHUB_PATH
echo "$(brew --prefix)/opt/gnu-sed/libexec/gnubin" >> $GITHUB_PATH
fi
- uses: docker-practice/actions-setup-docker@master
- name: Install Docker
# This uses a fork from
# https://github.com/docker-practice/actions-setup-docker The difference
# is that this waits up to 10 minutes for docker to start instead of
# just 3. The reason for this fork is that the original developer has
# not responded for almost a year while people have reported related
# issues and even made a pull request.
# uses: dfinity/actions-setup-docker@wait-longer-for-docker-to-start-up
uses: dfinity/actions-setup-docker@master
timeout-minutes: 12
daniel-wong-dfinity-org marked this conversation as resolved.
Show resolved Hide resolved
- name: Checkout
uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG-Nns-Dapp-unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ proposal is successful, the changes it released will be moved from this file to
* Fixed the formatting command in the `update-aggregator-response` GitHub workflow.
* Disambiguated the title of the docker reproducibility check.
* Change the number of accounts tested in `test-upgrade-map-stable` from 1000 to 20.
* Increased timeout for starting up docker from 3 min to 10 min in `reproducible` workflow.

#### Deprecated

Expand Down
Loading