Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default icrc canisters store #5383

Merged
merged 16 commits into from
Sep 2, 2024
Merged

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Sep 1, 2024

Motivation

We need to make the NNS-dapp treat imported tokens as ICRC tokens, just as it does with the current tokens, since imported tokens follow the ICRC standard. The only differences are that the index canister is optional (and the nns-dapp already handles this), and they are added by the user.

Note: This PR includes a solution suggested in another approach PR.

Changes

  1. Rename icrcCanistersStore to defaultIcrcCanistersStore.
  2. Introduce a new derived store that contains both the current ICRC canister IDs and imported token IDs, and give this store the old name icrcCanistersStore.
  3. Adjust the NNS-dapp code so that it reads the canister IDs from the derived store and writes to the renamed defaultIcrcCanistersStore.

Tests

  • Adjust tests to reflect the changes.
  • Test for icrcCanistersStore.
  • Tested manually that there are not current functionality changes.

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@mstrasinskis mstrasinskis marked this pull request as ready for review September 2, 2024 09:36
@mstrasinskis mstrasinskis requested a review from a team as a code owner September 2, 2024 09:36
@mstrasinskis mstrasinskis added this pull request to the merge queue Sep 2, 2024
Merged via the queue into main with commit 6481f7b Sep 2, 2024
30 checks passed
@mstrasinskis mstrasinskis deleted the mstr/default-icrc-canisters-store branch September 2, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants