Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: svelte v5 #6020

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
+486 −418
Draft

build: svelte v5 #6020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0f25c23
build: svelte v5
peterpeterparker Dec 17, 2024
996e923
chore: lint
peterpeterparker Dec 17, 2024
34cea00
feat: migration ComponentType to Component
peterpeterparker Dec 17, 2024
4953880
chore: redo
peterpeterparker Dec 17, 2024
724251e
build: bump testing libs
peterpeterparker Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added frontend/dfinity-gix-components-5.0.0.tgz
View file
Open in desktop
Binary file not shown.
848 changes: 458 additions & 390 deletions frontend/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@
"devDependencies": {
"@playwright/test": "^1.47.1",
"@rollup/plugin-inject": "^5.0.5",
"@sveltejs/adapter-static": "^3.0.5",
"@sveltejs/kit": "^2.8.3",
"@sveltejs/vite-plugin-svelte": "^3.1.2",
"@testing-library/jest-dom": "^6.6.2",
"@testing-library/svelte": "^5.2.3",
"@sveltejs/adapter-static": "^3.0.6",
"@sveltejs/kit": "^2.12.1",
"@sveltejs/vite-plugin-svelte": "^4.0.1",
"@testing-library/jest-dom": "^6.6.3",
"@testing-library/svelte": "^5.2.6",
"@testing-library/user-event": "^14.5.2",
"@types/wicg-file-system-access": "^2023.10.5",
"@typescript-eslint/eslint-plugin": "^6.8.0",
Expand All @@ -47,7 +47,7 @@
"dotenv": "^16.4.5",
"eslint": "^8.51.0",
"eslint-config-prettier": "^9.0.0",
"eslint-plugin-svelte": "^2.34.0",
"eslint-plugin-svelte": "^2.46.1",
"fake-indexeddb": "^6.0.0",
"jsdom": "^25.0.1",
"node-fetch": "^3.3.2",
Expand All @@ -56,8 +56,8 @@
"prettier-plugin-organize-imports": "^4.0.0",
"prettier-plugin-svelte": "^3.2.6",
"sass": "^1.69.4",
"svelte": "^4.2.19",
"svelte-check": "^4.0.2",
"svelte": "^5.14.1",
"svelte-check": "^4.1.1",
"svelte-preprocess": "^6.0.2",
"svelte2tsx": "^0.7.19",
"typescript": "^5.2.2",
Expand All @@ -72,7 +72,7 @@
"@dfinity/candid": "^2.1.3",
"@dfinity/ckbtc": "next",
"@dfinity/cmc": "next",
"@dfinity/gix-components": "next",
"@dfinity/gix-components": "file:dfinity-gix-components-5.0.0.tgz",
"@dfinity/ic-management": "next",
"@dfinity/identity": "^2.1.3",
"@dfinity/ledger-icp": "next",
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/lib/components/accounts/CkBTCInfoCard.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
{$i18n.ckbtc.receive_btc_title}
</h4>
<div class="content-cell-details info-section">
<p class="description">
<div class="description">
{$i18n.ckbtc.ckbtc_buzz_words}
{#if nonNullish(account)}
<Html
Expand All @@ -88,7 +88,7 @@
{/if}
</a>.
{/if}
</p>
</div>
</div>
</div>

Expand Down
2 changes: 1 addition & 1 deletion frontend/src/lib/components/accounts/SelectNetworkDropdown.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
testId="select-network-dropdown"
>
<option disabled selected value={undefined} class="hidden"
><span class="description">{$i18n.accounts.select_network}</span></option
>{$i18n.accounts.select_network}</option
>
<DropdownItem value={TransactionNetwork.ICP}
>{$i18n.accounts.network_icp}</DropdownItem
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/lib/components/accounts/WalletPageHeading.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
{/if}
</TooltipIcon>
</div>
<div class="vertical-divider" />
<div class="vertical-divider"></div>
{/if}<div class="account-name">
{accountName}
</div>
Expand Down
10 changes: 5 additions & 5 deletions frontend/src/lib/components/common/EmptyCards.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,19 @@

<div class="card-grid" data-tid="empty-cards-component">
<Card disabled>
<div class="card-item" />
<div class="card-item"></div>
</Card>
<Card disabled>
<div class="card-item" />
<div class="card-item"></div>
</Card>
<Card disabled>
<div class="card-item" />
<div class="card-item"></div>
</Card>
<Card disabled>
<div class="card-item" />
<div class="card-item"></div>
</Card>
<Card disabled>
<div class="card-item" />
<div class="card-item"></div>
</Card>
</div>

Expand Down
4 changes: 2 additions & 2 deletions frontend/src/lib/components/common/MenuItems.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
ThemeToggleButton,
} from "@dfinity/gix-components";
import { layoutMenuOpen, menuCollapsed } from "@dfinity/gix-components";
import type { ComponentType } from "svelte";
import type { Component } from "svelte";
import { cubicIn, cubicOut } from "svelte/easing";
import { scale } from "svelte/transition";

Expand All @@ -36,7 +36,7 @@
| typeof IconNeurons
| typeof IconVote
| typeof IconRocketLaunch;
statusIcon?: ComponentType;
statusIcon?: Component;
}[];
$: routes = [
{
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/lib/components/project-detail/CommitmentProgressBar.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
class="min-indicator"
data-tid="commitment-min-indicator"
style={`left: calc(${minIndicatorPosition}px);`}
/>
></span>
</div>
</div>
{/if}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/lib/components/ui/ProposalStatusTag.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
class="actionable-status-badge"
role="status"
transition:scale={{ duration: 250, easing: cubicOut }}
/>
></div>
</Tooltip>
</div>
{/if}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/lib/modals/neurons/SplitNnsNeuronModal.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<script lang="ts" xmlns:svelte="http://www.w3.org/1999/html">
<script lang="ts">
import CurrentBalance from "$lib/components/accounts/CurrentBalance.svelte";
import AmountInput from "$lib/components/ui/AmountInput.svelte";
import { icpAccountsStore } from "$lib/derived/icp-accounts.derived";
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/lib/routes/Settings.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@

<KeyValuePairInfo>
<p slot="key" class="label">{$i18n.settings.your_session}</p>
<p slot="value" class="value session" data-tid="session-duration">
<div slot="value" class="value session" data-tid="session-duration">
{#if nonNullish(remainingTimeMilliseconds)}
{remainingTimeMilliseconds <= 0
? "0"
Expand All @@ -64,7 +64,7 @@
{:else}
<div class="skeleton"><SkeletonText /></div>
{/if}
</p>
</div>

<svelte:fragment slot="info">
{$i18n.settings.your_session_description}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/tests/lib/components/accounts/IcrcBalancesObserverTest.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@
ledgerCanisterId={CKTESTBTC_LEDGER_CANISTER_ID}
{reload}
>
<div data-tid="test-observer" />
<div data-tid="test-observer"></div>
</IcrcBalancesObserver>
2 changes: 1 addition & 1 deletion frontend/src/tests/lib/components/accounts/IcrcWalletTransactionsObserverTest.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@
ledgerCanisterId={CKTESTBTC_LEDGER_CANISTER_ID}
indexCanisterId={CKTESTBTC_INDEX_CANISTER_ID}
>
<div data-tid="test-observer" />
<div data-tid="test-observer"></div>
</IcrcWalletTransactionsObserver>
2 changes: 1 addition & 1 deletion frontend/src/tests/lib/directives/IntersectionTest.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
import { onIntersection } from "$lib/directives/intersection.directives";
</script>

<div use:onIntersection />
<div use:onIntersection></div>
Loading