feat(frontend): imperative transaction network guard #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rd' into feat/imperative-transactions-guard
|
|
||
| await homepageLoggedIn.waitForContentReady(); | ||
|
|
||
| await expect(page).toHaveScreenshot({ fullPage: true }); |
There was a problem hiding this comment.
I think when we have more test cases like this one, we can create an additional method that validates which page is active without capturing a screenshot.
DenysKarmazynDFINITY
approved these changes
Dec 17, 2024
|
Require #3989 to pass - i.e. CI will fail until related PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With Svelte v5 #3949 we are not able to access the
/transactionspage because the$pagestore is not initalized when the route is mounted. This happens because we guard the page for case where thenetworkquery param would not be set. To resolve the issue we can imperatively access the query parameter.Changes
URLSearchParamsinstead of$pageto read thenetworkparam on mount.