feat(frontend): sol network derived #4001
Merged
+449
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feat(frontend)/sol-addresses
# Conflicts: # src/frontend/src/tests/lib/api/idb.api.spec.ts
- move method from sol-balance.services.ts to sol-address.services.ts
…ived' into feat(frontend)/sol-addresses-derived
…dresses-derived-2 # Conflicts: # src/frontend/src/sol/services/sol-address.services.ts # src/frontend/src/sol/types/network.ts # src/frontend/src/tests/sol/services/sol-address.services.spec.ts
…ding' into feat(frontend)/sol-addresses-loading # Conflicts: # src/frontend/src/tests/lib/components/guard/AddressGuard.spec.ts
|
needs #4000 to be in first |
DenysKarmazynDFINITY
approved these changes
Dec 17, 2024
| debounceLoadSolAddressDevnet(); | ||
| } | ||
| } | ||
|
|
||
| if (LOCAL) { | ||
| debounceLoadBtcAddressRegtest(); |
There was a problem hiding this comment.
Looks like, we forgot to check isNullish($btcAddressRegtest) here. Can you please add it? 😇
| @@ -37,6 +44,21 @@ export const isNetworkIdBTCRegtest = (networkId: NetworkId | undefined): boolean | |||
| export const isNetworkIdSepolia = (networkId: NetworkId | undefined): boolean => | |||
| SEPOLIA_NETWORK_ID === networkId; | |||
|
|
|||
| export const isNetworkIdSolana = (networkId: NetworkId | undefined): boolean => | |||
There was a problem hiding this comment.
Not necessarily for this PR, but I feel like having some common type IsNetworkIdUtil = (networkId: NetworkId | undefined): boolean is long overdue 🙈
There was a problem hiding this comment.
will follow up with a PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add SOL to network utils to be able to make conditional rendering of components in the application.
Changes
Tests