feat(frontend): add sol to receive addresses #4029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,10 @@ export const RECEIVE_TOKENS_MODAL_BTC_MAINNET_SECTION = 'receive-tokens-modal-bt | |||
| export const RECEIVE_TOKENS_MODAL_BTC_TESTNET_SECTION = 'receive-tokens-modal-btc-testnet-section'; | |||
| export const RECEIVE_TOKENS_MODAL_BTC_REGTEST_SECTION = 'receive-tokens-modal-btc-regtest-section'; | |||
| export const RECEIVE_TOKENS_MODAL_ETH_SECTION = 'receive-tokens-modal-eth-section'; | |||
| export const RECEIVE_TOKENS_MODAL_SOL_MAINNET_SECTION = 'receive-tokens-modal-sol-mainnet-section'; | |||
There was a problem hiding this comment.
Since you already added these vars, can you please add them to e2e/receive-tokens-modal.spec.ts? Otherwise, when we enable sol in the e2e env, the receive modal test will be failing due to different sol addresses in the modal on every run.
There was a problem hiding this comment.
sure, do the e2e test have the LOCAL flag to true? I added this one too
There was a problem hiding this comment.
Yes, LOCAL is true in the e2e env since we build and deploy the app the same way as we do it locally.
There was a problem hiding this comment.
I will have to comment them out until the SOLANA_NETWORK_ENABLED flag is set to true, otherwise e2e will fail
DenysKarmazynDFINITY
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add solana to receive addresses if feature is enabled.
Changes
Integrate SOL addresses into receiveAddresses
Tests
Uploading Bildschirmaufnahme 2024-12-19 um 11.52.43.mov…