Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lifeline_canister.wasm URL and enable demo_latest. #137

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dskloetd
Copy link
Collaborator

@dskloetd dskloetd commented Apr 26, 2023

Motivation

I saw this error in the failing CI run of demo_latest:

Downloading /Users/runner/.cache/dfinity/versions/0.13.1/wasms/lifeline.wasm
  from .gz: https://download.dfinity.systems/ic/446bd3de0b1d306bd3e0782d2d7386a7259fbd48/canisters/lifeline.wasm.gz
Error: Failed to install NNS components.
Caused by: Failed to install NNS components.
  Failed to download NNS wasm files.
    Failed to download lifeline.wasm from the IC CI.
      Failed to download and unzip '"/Users/runner/.cache/dfinity/versions/0.13.1/wasms/lifeline.wasm"' from '"https://download.dfinity.systems/ic/446bd3de0b1d306bd3e0782d2d7386a7259fbd48/canisters/lifeline.wasm.gz"'.
        Failed to unzip WASM to '/Users/runner/.cache/dfinity/versions/0.13.1/wasms/.tmpSZFsUW/wasm'
          invalid gzip header
Error: Process completed with exit code 255.

I tried the URL and it gave a 403.
I randomly tried changing the URL from lifeline.wasm.gz to lifeline_canister.wasm.gz and that did download a gzipped canister, so I guessed that would fix it.

Changes

  1. Download lifeline_canister.wasm.gz instead of lifeline.wasm.gz.
  2. Enable CI for demo_latest again.

@bitdivine
Copy link
Member

Suggestion: Update the known good ic commit (in bin/versions) to the current value.

@dskloetd
Copy link
Collaborator Author

I'm not working on this right now. Feel free to take it over if you want.
To me the current bin/dfx-nns-wasm-download feels too heavy to solve the problem.
If you don't, I may have another look after finishing some other things first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants