Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on source mdia #429

Merged
merged 9 commits into from
Dec 11, 2023
Merged

Conversation

josediegorobles
Copy link
Member

No description provided.

@josediegorobles josediegorobles marked this pull request as ready for review December 11, 2023 13:29
Copy link
Member

@crisdut crisdut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just naming convention adjustments.

Furthermore, shouldn't we change the name in web.rs, adding a "full_" prefix to the method, just like transfer?

src/structs.rs Outdated Show resolved Hide resolved
src/web.rs Outdated
Comment on lines 385 to 391
let media = match pre_req.meta {
Some(media) => {
let media = crate::rgb::import_uda_data(media).await;
Some(IssueMediaRequest::from(media.unwrap()))
}
None => None,
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How we work when occurs error here?

@crisdut crisdut self-requested a review December 11, 2023 16:32
@josediegorobles josediegorobles merged commit 8421459 into development Dec 11, 2023
3 of 5 checks passed
@josediegorobles josediegorobles deleted the JR/fix-error-source-media branch December 11, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants